Messages in this thread | | | Subject | Re: [PATCH v4 1/2] kernel.h: Update comment about simple_strto<foo>() functions | From | Joe Perches <> | Date | Thu, 01 Aug 2019 12:58:08 -0700 |
| |
On Thu, 2019-08-01 at 22:29 +0300, Andy Shevchenko wrote: > There were discussions in the past about use cases for > simple_strto<foo>() functions and, in some rare cases, > they have a benefit over kstrto<foo>() ones. [] > diff --git a/include/linux/kernel.h b/include/linux/kernel.h [] > @@ -334,8 +334,7 @@ int __must_check kstrtoll(const char *s, unsigned int base, long long *res); > * @res: Where to write the result of the conversion on success. > * > * Returns 0 on success, -ERANGE on overflow and -EINVAL on parsing error. > - * Used as a replacement for the obsolete simple_strtoull. Return code must > - * be checked. > + * Used as a replacement for the simple_strtoull. Return code must be checked.
Using 'the' here is unnecessary and somewhat confusing.
Perhaps:
* Preferred over simple_strtoull() unless the end position is required * Return value must be checked
>
| |