lkml.org 
[lkml]   [2019]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] iommu/vt-d: Refactor find_domain() helper
From
Date
Hi Christoph,

On 8/1/19 2:10 PM, Christoph Hellwig wrote:
> On Thu, Aug 01, 2019 at 02:01:54PM +0800, Lu Baolu wrote:
>> + /* No lock here, assumes no domain exit in normal case */
>
> s/exit/exists/ ?

This comment is just moved from one place to another in this patch.

"no domain exit" means "the domain isn't freed". (my understand)

>
>> + info = dev->archdata.iommu;
>> + if (likely(info))
>> + return info->domain;
>
> But then again the likely would be odd.
>

Normally there's a domain for a device (default domain or isolation
domain for assignment cases).

Best regards,
Baolu

\
 
 \ /
  Last update: 2019-08-01 08:21    [W:0.046 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site