Messages in this thread | | | Date | Thu, 1 Aug 2019 18:32:13 +0200 | From | Michal Hocko <> | Subject | Re: [BUG]: mm/vmscan.c: shrink_slab does not work correctly with memcg disabled via commandline |
| |
On Thu 01-08-19 17:54:34, Jan Hadrava wrote: > On Thu, Aug 01, 2019 at 04:06:10PM +0200, Michal Hocko wrote: > > On Thu 01-08-19 15:42:50, Jan Hadrava wrote: > > > There seems to be a bug in mm/vmscan.c shrink_slab function when kernel is > > > compilled with CONFIG_MEMCG=y and it is then disabled at boot with commandline > > > parameter cgroup_disable=memory. SLABs are then not getting shrinked if the > > > system memory is consumed by userspace. > > > > This looks similar to http://lkml.kernel.org/r/1563385526-20805-1-git-send-email-yang.shi@linux.alibaba.com > > although the culprit commit has been identified to be different. Could > > you try it out please? Maybe we need more fixes. > > Yes, it is same.
I am happy to hear that!
> So my report is duplicate and I'm just bad in searching the > archives, sorry.
No worries. Your bug report was really good with great level of details. I wish all the bug reports were done so thoroughly.
> Just to be sure, i run my tests and patch proposed in the original thread > solves my issue in all four affected stable releases:
Cc Andrew. I assume we can assume your Tested-by tag?
Thanks a lot! -- Michal Hocko SUSE Labs
| |