Messages in this thread | | | Date | Thu, 1 Aug 2019 09:15:02 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v2] tracing: Function stack size and its name mismatch in arm64 |
| |
On Thu, 1 Aug 2019 16:33:40 +0800 Jiping Ma <jiping.ma2@windriver.com> wrote:
> diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c > index 5d16f73898db..ed80b95abf06 100644 > --- a/kernel/trace/trace_stack.c > +++ b/kernel/trace/trace_stack.c > @@ -40,16 +40,28 @@ static void print_max_stack(void) > > pr_emerg(" Depth Size Location (%d entries)\n" > " ----- ---- --------\n", > +#ifdef CONFIG_ARM64 > + stack_trace_nr_entries - 1); > +#else > stack_trace_nr_entries); > -
NACK! I do not allow arch specific code in generic code like this.
The stack saving should be the same across all archs. If it is not, it is a bug with the arch that is different.
-- Steve
| |