Messages in this thread | | | Date | Thu, 1 Aug 2019 13:41:21 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 3/3][V4] dt-bindings: iio: imu: add bindings for ADIS16460 |
| |
On Mon, 29 Jul 2019 17:24:40 -0600 Rob Herring <robh+dt@kernel.org> wrote:
> On Sat, Jul 27, 2019 at 12:56 PM Jonathan Cameron <jic23@kernel.org> wrote: > > > > On Tue, 23 Jul 2019 10:36:40 +0300 > > Alexandru Ardelean <alexandru.ardelean@analog.com> wrote: > > > > > This change adds device-tree bindings for the ADIS16460. > > > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > > > > Really trivial, but convention (as driven by what git am -s does if nothing > > else, is to add extra tags in chronological order. So Rob would be after > > you. I tweaked it which I don't always remember to do. > > I'd argue it is in chronological order as the submitter added my tag > and then sent it out. If you applied it and added my tag, then it > would be after (but before yours).
Bike shedding to follow...
Possibly but given you gave the Reviewed-by for v2, and it hasn't changed is Alex's the same Signed-off-by as seen on V2, or a new one reflecting the addition of your Reviewed-by?
:)
> > > It's not consistent across the kernel but I'll fight for my little corner > > to be :) > > More consistency would be nice then there's less tribal knowledge > about maintainers for submitters to learn.
Agreed.
Jonathan
> > Rob
| |