Messages in this thread | | | From | Miklos Szeredi <> | Date | Thu, 1 Aug 2019 13:01:33 +0200 | Subject | Re: [PATCH] fuse: BUG_ON's correction in fuse_dev_splice_write() |
| |
On Tue, Jul 23, 2019 at 8:33 AM Vasily Averin <vvs@virtuozzo.com> wrote: > > commit 963545357202 ("fuse: reduce allocation size for splice_write") > changed size of bufs array, so first BUG_ON should be corrected too. > Second BUG_ON become useless, first one also includes the second check: > any unsigned nbuf value cannot be less than 0.
This patch seems broken: it assumes that pipe->nrbufs doesn't change. Have you actually tested it?
Thanks, Miklos
| |