Messages in this thread | | | Date | Thu, 1 Aug 2019 11:23:48 +0200 | From | Greg Kurz <> | Subject | Re: [PATCH 1/2] powerpc/xive: Use GFP_KERNEL instead of GFP_ATOMIC in 'xive_irq_bitmap_add()' |
| |
On Thu, 1 Aug 2019 10:32:31 +0200 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> There is no need to use GFP_ATOMIC here. GFP_KERNEL should be enough. > GFP_KERNEL is also already used for another allocation just a few lines > below. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > ---
Good catch.
Reviewed-by: Greg Kurz <groug@kaod.org>
> arch/powerpc/sysdev/xive/spapr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c > index 8ef9cf4ebb1c..b4f5eb9e0f82 100644 > --- a/arch/powerpc/sysdev/xive/spapr.c > +++ b/arch/powerpc/sysdev/xive/spapr.c > @@ -45,7 +45,7 @@ static int xive_irq_bitmap_add(int base, int count) > { > struct xive_irq_bitmap *xibm; > > - xibm = kzalloc(sizeof(*xibm), GFP_ATOMIC); > + xibm = kzalloc(sizeof(*xibm), GFP_KERNEL); > if (!xibm) > return -ENOMEM; >
| |