Messages in this thread | | | From | Naga Sureshkumar Relli <> | Subject | RE: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() | Date | Thu, 1 Aug 2019 04:47:48 +0000 |
| |
Hi Tudor,
> -----Original Message----- > From: Tudor.Ambarus@microchip.com <Tudor.Ambarus@microchip.com> > Sent: Wednesday, July 31, 2019 6:37 PM > To: Naga Sureshkumar Relli <nagasure@xilinx.com>; boris.brezillon@collabora.com; > marek.vasut@gmail.com; vigneshr@ti.com > Cc: richard@nod.at; linux-kernel@vger.kernel.org; linux-mtd@lists.infradead.org; > miquel.raynal@bootlin.com; computersforpeace@gmail.com; dwmw2@infradead.org > Subject: Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() > > Hi, Naga, > > On 07/31/2019 03:31 PM, Naga Sureshkumar Relli wrote: > >> + if (nor->info->flags & SPI_S3AN) > >> + s3an_post_sfdp_fixups(nor); > >> } > >> > > Instead of checking the flags, why can't we call directly the nor_fixups? > > like Boris implementation nor->info->fixups->post_sfdp() > > https://patchwork.ozlabs.org/patch/1009291/ > > This check will vanish and nor->info->fixups->post_sfdp() will be called directly once I'll > respin the manufacturer driver part. post_sfdp() will set just flash parameters. Check Boris' > patch at https://patchwork.ozlabs.org/patch/1009295/ > > I'll try to respin the rest of Boris' patches sometime at the beginning of the next week. Ok, Thanks.
Regards, Naga Sureshkumar Relli > > Cheers, > ta
| |