Messages in this thread | | | From | Chunyan Zhang <> | Date | Fri, 2 Aug 2019 09:57:05 +0800 | Subject | Re: [PATCH 7/9] clk: sprd: Don't reference clk_init_data after registration |
| |
On Thu, 1 Aug 2019 at 03:35, Stephen Boyd <sboyd@kernel.org> wrote: > > A future patch is going to change semantics of clk_register() so that > clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid > referencing this member here so that we don't run into NULL pointer > exceptions. > > Cc: Chunyan Zhang <zhang.chunyan@linaro.org> > Cc: Baolin Wang <baolin.wang@linaro.org> > Signed-off-by: Stephen Boyd <sboyd@kernel.org> > --- > > Please ack so I can take this through clk tree
Acked-by: Chunyan Zhang <zhang.chunyan@linaro.org>
Thanks.
> > drivers/clk/sprd/common.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c > index a5bdca1de5d0..9d56eac43832 100644 > --- a/drivers/clk/sprd/common.c > +++ b/drivers/clk/sprd/common.c > @@ -76,16 +76,17 @@ int sprd_clk_probe(struct device *dev, struct clk_hw_onecell_data *clkhw) > struct clk_hw *hw; > > for (i = 0; i < clkhw->num; i++) { > + const char *name; > > hw = clkhw->hws[i]; > - > if (!hw) > continue; > > + name = hw->init->name; > ret = devm_clk_hw_register(dev, hw); > if (ret) { > dev_err(dev, "Couldn't register clock %d - %s\n", > - i, hw->init->name); > + i, name); > return ret; > } > } > -- > Sent by a computer through tubes >
| |