Messages in this thread | | | Date | Tue, 9 Jul 2019 19:24:58 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated |
| |
On Mon, Jul 08, 2019 at 01:34:59PM -0700, James Bottomley wrote: > Not a criticism of your patch, but can we please stop doing this. > Single random number sources are horrendously bad practice because it > gives an attacker a single target to subvert. We should ensure the TPM > is plugged into the kernel RNG as a source and then take randomness > from the mixed pool so it's harder for an attacker because they have to > subvert all our sources to predict what came out.
It is and I agree.
/Jarkko
| |