lkml.org 
[lkml]   [2019]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [for-next][PATCH 12/16] kprobes: Initialize kprobes at postcore_initcall
On Wed, 3 Jul 2019 10:25:04 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 3 Jul 2019 10:24:02 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > On Wed, 3 Jul 2019 15:08:32 +0100
> > Catalin Marinas <catalin.marinas@arm.com> wrote:
> >
> >
> > > > +static int __init run_init_test_probes(void)
> > > > +{
> > > > + if (run_kprobe_tests)
> > > > + init_test_probes();
> > >
> > > A return 0 here.
> >
> > Will update (would have triggered a failure on my test suite anyway ;-)
> >
> > >
> > > > +}
> > > > +module_init(run_init_test_probes);
> > >
> > > This does the trick. I prefer your fix as it leaves the arch code
> > > unchanged. In case you need it:
> > >
> > > Tested-by: Catalin Marinas <catalin.marinas@arm.com>
> > >
> >
>
> Masami,
>
> If you give me an Acked-by, I'll add it to my tree.

Sorry for late reply, but I want to keep the test running right after
initialization as the first user of kprobes at that timing, since
other user can start using kprobes right after init_kprobes().
So this issue must be fixed in moving the init_kprobes() itself
right after arch_initcall() (and that is subsys_initcall)

Catalin, Mark, could you ensure the below patch can fix your issue?

https://lore.kernel.org/lkml/20190625191545.245259106@goodmis.org/

And if so, Steve, could you push above one (which seems already in your
tree) to next as a fix?

Thank you,

--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2019-07-09 14:52    [W:0.073 / U:1.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site