Messages in this thread | | | Subject | Re: [PATCH v2] tpm: tpm_ibm_vtpm: Fix unallocated banks | From | Jarkko Sakkinen <> | Date | Mon, 08 Jul 2019 18:11:40 +0300 |
| |
On Sat, 2019-07-06 at 20:18 -0400, Nayna Jain wrote: > +/* > + * tpm_get_pcr_allocation() - initialize the chip allocated banks for PCRs > + * @chip: TPM chip to use. > + */ > +static int tpm_get_pcr_allocation(struct tpm_chip *chip) > +{ > + int rc; > + > + if (chip->flags & TPM_CHIP_FLAG_TPM2) > + rc = tpm2_get_pcr_allocation(chip); > + else > + rc = tpm1_get_pcr_allocation(chip); > + > + return rc; > +}
It is just a trivial static function, which means that kdoc comment is not required and neither it is useful. Please remove that. I would rewrite the function like:
static int tpm_get_pcr_allocation(struct tpm_chip *chip) { int rc;
rc = (chip->flags & TPM_CHIP_FLAG_TPM2) ? tpm2_get_pcr_allocation(chip) : tpm1_get_pcr_allocation(chip);
return rc > 0 ? -ENODEV : rc; }
This addresses the issue that Stefan also pointed out. You have to deal with the TPM error codes.
/Jarkko
| |