Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH v2] powerpc/mm: mark more tlb functions as __always_inline | Date | Mon, 8 Jul 2019 11:19:33 +1000 (AEST) |
| |
On Tue, 2019-05-21 at 13:13:24 UTC, Masahiro Yamada wrote: > With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error > with gcc 9.1.1: > > arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': > arch/powerpc/mm/book3s64/radix_tlb.c:104:2: warning: asm operand 3 probably doesn't match constraints > 104 | asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1) > | ^~~ > arch/powerpc/mm/book3s64/radix_tlb.c:104:2: error: impossible constraint in 'asm' > > Fixing _tlbiel_pid() is enough to address the warning above, but I > inlined more functions to fix all potential issues. > > To meet the "i" (immediate) constraint for the asm operands, functions > propagating "ric" must be always inlined. > > Fixes: 9012d011660e ("compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING") > Reported-by: Laura Abbott <labbott@redhat.com> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6d3ca7e73642ce17398f4cd5df1780da4a1ccdaf
cheers
| |