lkml.org 
[lkml]   [2019]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 009/129] clk: vf610: fix refcount leak in vf610_clocks_init()
    3.16.70-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yangtao Li <tiny.windzz@gmail.com>

    commit 567177024e0313e4f0dcba7ba10c0732e50e655d upstream.

    The of_find_compatible_node() returns a node pointer with refcount
    incremented, but there is the lack of use of the of_node_put() when
    done. Add the missing of_node_put() to release the refcount.

    Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    Fixes: 1f2c5fd5f048 ("ARM: imx: add VF610 clock support")
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    [bwh: Backported to 3.16: adjust filename]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/arm/mach-imx/clk-vf610.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/arch/arm/mach-imx/clk-vf610.c
    +++ b/arch/arm/mach-imx/clk-vf610.c
    @@ -117,6 +117,7 @@ static void __init vf610_clocks_init(str
    np = of_find_compatible_node(NULL, NULL, "fsl,vf610-anatop");
    anatop_base = of_iomap(np, 0);
    BUG_ON(!anatop_base);
    + of_node_put(np);

    np = ccm_node;
    ccm_base = of_iomap(np, 0);
    \
     
     \ /
      Last update: 2019-07-07 21:45    [W:4.054 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site