Messages in this thread | | | Subject | Re: [PATCH 1/3] drm/bridge: sii902x: fix missing reference to mclk clock | From | Jyri Sarha <> | Date | Thu, 4 Jul 2019 11:03:21 +0300 |
| |
On 02/07/2019 18:47, Olivier Moysan wrote: > Add devm_clk_get call to retrieve reference to master clock. > > Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") > > Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
Reviewed-by: Jyri Sarha <jsarha@ti.com>
I wonder how that line was dropped and how the code past my final test. Any way, this fix is definitely needed.
Thanks, Jyri
> --- > drivers/gpu/drm/bridge/sii902x.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c > index dd7aa466b280..36acc256e67e 100644 > --- a/drivers/gpu/drm/bridge/sii902x.c > +++ b/drivers/gpu/drm/bridge/sii902x.c > @@ -750,6 +750,7 @@ static int sii902x_audio_codec_init(struct sii902x *sii902x, > sii902x->audio.i2s_fifo_sequence[i] |= audio_fifo_id[i] | > i2s_lane_id[lanes[i]] | SII902X_TPI_I2S_FIFO_ENABLE; > > + sii902x->audio.mclk = devm_clk_get(dev, "mclk"); > if (IS_ERR(sii902x->audio.mclk)) { > dev_err(dev, "%s: No clock (audio mclk) found: %ld\n", > __func__, PTR_ERR(sii902x->audio.mclk)); >
-- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
| |