Messages in this thread | | | From | Arnd Bergmann <> | Date | Wed, 31 Jul 2019 17:47:33 +0200 | Subject | Re: [PATCH v5 15/29] compat_ioctl: move tape handling into drivers |
| |
On Wed, Jul 31, 2019 at 12:51 PM Heiko Carstens <heiko.carstens@de.ibm.com> wrote: > > On Tue, Jul 30, 2019 at 09:55:31PM +0200, Arnd Bergmann wrote: > > MTIOCPOS and MTIOCGET are incompatible between 32-bit and 64-bit user > > space, and traditionally have been translated in fs/compat_ioctl.c. > > > > To get rid of that translation handler, move a corresponding > > implementation into each of the four drivers implementing those commands. > > > > The interesting part of that is now in a new linux/mtio.h header that > > wraps the existing uapi/linux/mtio.h header and provides an abstraction > > to let drivers handle both cases easily. Using an in_compat_syscall() > > check, the caller does not have to keep track of whether this was > > called through .unlocked_ioctl() or .compat_ioctl(). > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Besides the two minor things below > > Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Thanks a lot for the reviewed. Both issues are fixed now, and I'm pushing out new git branches after adding the other Acks I got so far.
Arnd
| |