lkml.org 
[lkml]   [2019]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 05/10] firmware: arm_scpi: convert platform driver to use dev_groups
    Date
    Platform drivers now have the option to have the platform core create
    and remove any needed sysfs attribute files. So take advantage of that
    and do not register "by hand" a sysfs group of attributes.

    Acked-by: Sudeep Holla <sudeep.holla@arm.com>
    Cc: linux-arm-kernel@lists.infradead.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/firmware/arm_scpi.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
    index 725164b83242..a80c331c3a6e 100644
    --- a/drivers/firmware/arm_scpi.c
    +++ b/drivers/firmware/arm_scpi.c
    @@ -1011,10 +1011,6 @@ static int scpi_probe(struct platform_device *pdev)
    scpi_info->firmware_version));
    scpi_info->scpi_ops = &scpi_ops;

    - ret = devm_device_add_groups(dev, versions_groups);
    - if (ret)
    - dev_err(dev, "unable to create sysfs version group\n");
    -
    return devm_of_platform_populate(dev);
    }

    @@ -1030,6 +1026,7 @@ static struct platform_driver scpi_driver = {
    .driver = {
    .name = "scpi_protocol",
    .of_match_table = scpi_of_match,
    + .dev_groups = versions_groups,
    },
    .probe = scpi_probe,
    .remove = scpi_remove,
    --
    2.22.0
    \
     
     \ /
      Last update: 2019-07-31 14:45    [W:2.344 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site