lkml.org 
[lkml]   [2019]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices()
    Hi,

    > > In delayedwork_callback(), logi_dj_recv_query_paired_devices
    > > may return positive value while success now, so check it
    > > correctly.

    > > Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices")
    > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    > Reviewed-by: Petr Vorel <pvorel@suse.cz>
    OK, not only it didn't fix problems with logitech mouse (see below),
    but removing mouses USB dongle effectively crashes kernel, so this one probably
    shouldn't be applied :).

    [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with error 7
    [ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: logi_dj_recv_query_paired_devices error: 7

    Kind regards,
    Petr

    \
     
     \ /
      Last update: 2019-07-31 13:07    [W:2.539 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site