Messages in this thread | | | Date | Wed, 31 Jul 2019 11:11:27 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 0/5] Ziirave_wdt driver fixes |
| |
On Wed, Jul 31, 2019 at 10:42:47AM -0700, Andrey Smirnov wrote: > Everyone, > > This series contains various fixes/improvements for ziirave_wdt > driver. Hopefully each commit is self-explanatory. > > Feedback is welcome! > > Thanks, > Andrey Smirnov > > Andrey Smirnov (5): > watchdog: ziirave_wdt: Add missing newline > watchdog: ziirave_wdt: Be verbose about errors in probe() > watchdog: ziirave_wdt: Be more verbose during firmware update > watchdog: ziirave_wdt: Don't bail out on unexpected timeout value > watchdog: ziirave_wdt: Log bootloader/firmware info during probe
Since you are touching the driver, I would suggest another change: Use devm_watchdog_register_device() and drop the remove function.
Guenter
| |