lkml.org 
[lkml]   [2019]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG
Date
Quoting Taniya Das (2019-07-30 03:51:07)
>
>
> On 7/17/2019 4:52 AM, Stephen Boyd wrote:
> > Quoting Taniya Das (2019-07-15 21:22:02)
> >> Hello Stephen,
> >>
> >> Thanks for the review.
> >>
> >> On 7/16/2019 4:14 AM, Stephen Boyd wrote:
> >>> Quoting Taniya Das (2019-05-12 20:44:46)
> >>>> On 5/10/2019 11:24 PM, Stephen Boyd wrote:
> >>>>> Why is the clk name changing to not have a _src after the "root" of the
> >>>>> clk name? As long as I can remember, RCGs have a "_src" postfix.
> >>>>>
> >>>>
> >>>> Yes, the RCGs would have _src, so we do want the init data also to be
> >>>> generated with _src postfix. So that we do not have to manually clean up
> >>>> the generated code.
> >>>>
> >>>
> >>> Please manually cleanup the generated code, or fix the code
> >>> generator to do what you want.
> >>>
> >>
> >> Fixing the code manually is not what we intend to do and it is time
> >> consuming with too many DFS controlled clocks. This really helps us
> >> align to internal code.
> >>
> >
> > And you can't fix the code generator to drop the _src part of whatever
> > is spit out for the DFS lines?
> >
>
> Sure, will drop this.
>

Actually, I'm OK with this patch, but I'd like to see it in a larger
series that introduces another clk driver using this macro. The reason I
like it is that I can search for the same string name and find the clk
that has DFS enabled on it, instead of finding the branch which doesn't
have DFS. Sorry for the back and forth, I got confused about what was
going on.

\
 
 \ /
  Last update: 2019-07-30 17:41    [W:0.087 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site