Messages in this thread | | | Subject | Re: [PATCH 09/14] sched,fair: refactor enqueue/dequeue_entity | From | Rik van Riel <> | Date | Tue, 30 Jul 2019 08:58:48 -0400 |
| |
On Tue, 2019-07-30 at 11:36 +0200, Peter Zijlstra wrote: > On Mon, Jul 22, 2019 at 01:33:43PM -0400, Rik van Riel wrote: > > @@ -3870,6 +3873,24 @@ static inline void > > check_schedstat_required(void) > > * CPU and an up-to-date min_vruntime on the destination CPU. > > */ > > > > +static bool > > +enqueue_entity_groups(struct cfs_rq *cfs_rq, struct sched_entity > > *se, int flags) > > +{ > > + /* > > + * When enqueuing a sched_entity, we must: > > + * - Update loads to have both entity and cfs_rq synced with > > now. > > + * - Add its load to cfs_rq->runnable_avg > > + * - For group_entity, update its weight to reflect the new > > share of > > + * its group cfs_rq > > + * - Add its new weight to cfs_rq->load.weight > > + */ > > + if (!update_load_avg(cfs_rq, se, UPDATE_TG | DO_ATTACH)) > > + return false; > > + > > + update_cfs_group(se); > > + return true; > > +} > > > > No functional, but you did make update_cfs_group() conditional. Now > that > looks OK, but maybe you can do that part in a separate patch with a > little justification of its own.
Good idea, I will split that out.
-- All Rights Reversed. [unhandled content-type:application/pgp-signature] | |