Messages in this thread | | | From | Iuliana Prodan <> | Subject | Re: [PATCH v4 01/14] crypto: caam/qi - fix error handling in ERN handler | Date | Tue, 30 Jul 2019 12:08:55 +0000 |
| |
On 7/30/2019 2:06 PM, Iuliana Prodan wrote: > From: Horia Geantă <horia.geanta@nxp.com> > > ERN handler calls the caam/qi frontend "done" callback with a status > of -EIO. This is incorrect, since the callback expects a status value > meaningful for the crypto engine - hence the cryptic messages > like the one below: > platform caam_qi: 15: unknown error source > > Fix this by providing the callback with: > -the status returned by the crypto engine (fd[status]) in case > it contains an error, OR > -a QI "No error" code otherwise; this will trigger the message: > platform caam_qi: 50000000: Queue Manager Interface: No error > which is fine, since QMan driver provides details about the cause of > failure > > Cc: <stable@vger.kernel.org> # v5.1+ > Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend support") > Signed-off-by: Horia Geantă <horia.geanta@nxp.com> > --- Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Thanks, Iulia
| |