Messages in this thread | | | From | Jerome Brunet <> | Subject | Re: [PATCH 2/2] clk: meson: axg-audio: add g12a reset support | Date | Tue, 30 Jul 2019 09:16:37 +0200 |
| |
On Mon 29 Jul 2019 at 15:29, Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Jerome Brunet (2019-07-03 05:26:14) >> @@ -1005,8 +1087,27 @@ static int axg_audio_clkc_probe(struct platform_device *pdev) >> } >> } >> >> - return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, >> - data->hw_onecell_data); >> + ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, >> + data->hw_onecell_data); >> + if (ret) >> + return ret; >> + >> + /* Stop here if there is no reset */ >> + if (!data->reset_num) >> + return 0; >> + >> + rst = devm_kzalloc(dev, sizeof(*rst), GFP_KERNEL); >> + if (!rst) >> + return -ENOMEM; >> + >> + rst->map = map; >> + rst->offset = data->reset_offset; >> + rst->rstc.nr_resets = data->reset_num; >> + rst->rstc.ops = &axg_audio_rstc_ops; >> + rst->rstc.of_node = dev->of_node; >> + rst->rstc.owner = THIS_MODULE; >> + >> + return ret = devm_reset_controller_register(dev, &rst->rstc); > > IS this a typo? Just return devm instead?
Typo it is. Thanks for pointing it out.
> >> } >> >> static const struct audioclk_data axg_audioclk_data = {
| |