lkml.org 
[lkml]   [2019]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/1] mm/vmalloc.c: Fix percpu free VM area search criteria
From
Date
On 7/30/19 1:46 PM, Uladzislau Rezki wrote:
>> + /*
>> + * If required width exeeds current VA block, move
>> + * base downwards and then recheck.
>> + */
>> + if (base + end > va->va_end) {
>> + base = pvm_determine_end_from_reverse(&va, align) - end;
>> + term_area = area;
>> + continue;
>> + }
>> +
>> /*
>> * If this VA does not fit, move base downwards and recheck.
>> */
>> - if (base + start < va->va_start || base + end > va->va_end) {
>> + if (base + start < va->va_start) {
>> va = node_to_va(rb_prev(&va->rb_node));
>> base = pvm_determine_end_from_reverse(&va, align) - end;
>> term_area = area;
>> --
>> 2.21.0
>>
> I guess it is NUMA related issue, i mean when we have several
> areas/sizes/offsets. Is that correct?

I don't think NUMA has anything to do with it. The vmalloc() area
itself doesn't have any NUMA properties I can think of. We don't, for
instance, partition it into per-node areas that I know of.

I did encounter this issue on a system with ~100 logical CPUs, which is
a moderate amount these days.

\
 
 \ /
  Last update: 2019-07-30 22:55    [W:0.159 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site