Messages in this thread | | | Subject | Re: [PATCH] powerpc/hw_breakpoint: move instruction stepping out of hw_breakpoint_handler() | From | Ravi Bangoria <> | Date | Wed, 3 Jul 2019 11:50:17 +0530 |
| |
On 6/28/19 9:25 PM, Christophe Leroy wrote: > On 8xx, breakpoints stop after executing the instruction, so > stepping/emulation is not needed. Move it into a sub-function and > remove the #ifdefs. > > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> > ---
Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Just one neat below...
[...]
> -#ifndef CONFIG_PPC_8xx > - /* Do not emulate user-space instructions, instead single-step them */ > - if (user_mode(regs)) { > - current->thread.last_hit_ubp = bp; > - regs->msr |= MSR_SE; > + if (!IS_ENABLED(CONFIG_PPC_8xx) && !stepping_handler(regs, bp, info->address))
May be split this line. It's 86 chars long and checkpatch.pl is warning about this:
WARNING: line over 80 characters #257: FILE: arch/powerpc/kernel/hw_breakpoint.c:282: + if (!IS_ENABLED(CONFIG_PPC_8xx) && !stepping_handler(regs, bp, info->address))
| |