lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 089/293] net: hns3: fix a -Wformat-nonliteral compile warning
    Date
    [ Upstream commit 18d219b783da61a6cc77581f55fc4af2fa16bc36 ]

    When setting -Wformat=2, there is a compiler warning like this:

    hclge_main.c:xxx:x: warning: format not a string literal and no
    format arguments [-Wformat-nonliteral]
    strs[i].desc);
    ^~~~

    This patch adds missing format parameter "%s" to snprintf() to
    fix it.

    Fixes: 46a3df9f9718 ("Add HNS3 Acceleration Engine & Compatibility Layer Support")
    Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>
    Signed-off-by: Peng Li <lipeng321@huawei.com>
    Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
    index 654aad6e748b..86523e8993cb 100644
    --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
    @@ -619,8 +619,7 @@ static u8 *hclge_comm_get_strings(u32 stringset,
    return buff;

    for (i = 0; i < size; i++) {
    - snprintf(buff, ETH_GSTRING_LEN,
    - strs[i].desc);
    + snprintf(buff, ETH_GSTRING_LEN, "%s", strs[i].desc);
    buff = buff + ETH_GSTRING_LEN;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-07-29 21:39    [W:2.465 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site