lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] locking/rwsem: Add missing ACQUIRE to read_slowpath exit when queue is empty
On Fri, Jul 19, 2019 at 10:49:56AM +0200, Andrea Parri wrote:
> > @@ -1032,6 +1032,8 @@ rwsem_down_read_slowpath(struct rw_semap
> > */
> > if (adjustment && !(atomic_long_read(&sem->count) &
> > (RWSEM_WRITER_MASK | RWSEM_FLAG_HANDOFF))) {
> > + /* Provide lock ACQUIRE */
> > + smp_acquire__after_ctrl_dep();
>
> Does this also make the lock RCtso? Or maybe RCtso was already
> guaranteed (and I'm failing to see why)?

I didn't specifically look for that, but I suspect not, esp given the
next patch.

\
 
 \ /
  Last update: 2019-07-29 17:25    [W:0.062 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site