Messages in this thread | | | Date | Mon, 29 Jul 2019 17:24:28 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 1/4] locking/rwsem: Add missing ACQUIRE to read_slowpath exit when queue is empty |
| |
On Fri, Jul 19, 2019 at 10:49:56AM +0200, Andrea Parri wrote: > > @@ -1032,6 +1032,8 @@ rwsem_down_read_slowpath(struct rw_semap > > */ > > if (adjustment && !(atomic_long_read(&sem->count) & > > (RWSEM_WRITER_MASK | RWSEM_FLAG_HANDOFF))) { > > + /* Provide lock ACQUIRE */ > > + smp_acquire__after_ctrl_dep(); > > Does this also make the lock RCtso? Or maybe RCtso was already > guaranteed (and I'm failing to see why)?
I didn't specifically look for that, but I suspect not, esp given the next patch.
| |