lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] platform/chrome: cros_ec_trace: update generating script
From
Date
Hi Tzung-Bi

On 23/7/19 15:33, Tzung-Bi Shih wrote:
> To remove ", \" from the last line.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
> Changes from v1:
> - simpler awk code
>
> drivers/platform/chrome/cros_ec_trace.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_trace.c b/drivers/platform/chrome/cros_ec_trace.c
> index 0a76412095a9..667460952dad 100644
> --- a/drivers/platform/chrome/cros_ec_trace.c
> +++ b/drivers/platform/chrome/cros_ec_trace.c
> @@ -6,7 +6,18 @@
> #define TRACE_SYMBOL(a) {a, #a}
>
> // Generate the list using the following script:
> -// sed -n 's/^#define \(EC_CMD_[[:alnum:]_]*\)\s.*/\tTRACE_SYMBOL(\1), \\/p' include/linux/mfd/cros_ec_commands.h
> +// sed -n 's/^#define \(EC_CMD_[[:alnum:]_]*\)\s.*/\tTRACE_SYMBOL(\1), \\/p' \

For some reason I accepted the patch using c++ style comments but I shouldn't,
while we are here could you update the patch and use c style comments instead,
thanks.

~ Enric

> +// include/linux/mfd/cros_ec_commands.h | awk '
> +// {
> +// if (NR != 1)
> +// print buf;
> +// buf = $0;
> +// }
> +// END {
> +// gsub(/, \\/, "", buf);
> +// print buf;
> +// }
> +// '
> #define EC_CMDS \
> TRACE_SYMBOL(EC_CMD_PROTO_VERSION), \
> TRACE_SYMBOL(EC_CMD_HELLO), \
>

\
 
 \ /
  Last update: 2019-07-29 14:53    [W:0.028 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site