Messages in this thread | | | Date | Mon, 29 Jul 2019 13:50:13 +0100 | From | Mark Rutland <> | Subject | Re: [PATCH v9 10/21] mm: Add generic p?d_leaf() macros |
| |
On Sun, Jul 28, 2019 at 05:14:31PM +0530, Anshuman Khandual wrote: > On 07/23/2019 03:11 PM, Mark Rutland wrote: > > It might also be worth pointing out the reasons for this naming, e.g. > > p?d_large() aren't currently generic, and this name minimizes potential > > confusion between p?d_{large,huge}(). > > Agreed. But these fallback also need to first check non-availability of large > pages.
We're deliberately not making the p?d_large() helpers generic, so this shouldn't fall back on those.
It's up to the architecture to implement these correctly, and the architecture-specific implementations will be added in subsequent patches.
Thanks, Mark.
| |