lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] locking/mutex: Use mutex flags macro instead of hard code value
On Mon, Jul 29, 2019 at 04:22:58PM +0530, Mukesh Ojha wrote:
> Let's use the mutex flag macro(which got moved from mutex.c
> to linux/mutex.h in the last patch) instead of hard code
> value which was used in __mutex_owner().
>
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
> ---
> include/linux/mutex.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mutex.h b/include/linux/mutex.h
> index 79b28be..c3833ba 100644
> --- a/include/linux/mutex.h
> +++ b/include/linux/mutex.h
> @@ -87,7 +87,7 @@ struct mutex {
> */
> static inline struct task_struct *__mutex_owner(struct mutex *lock)
> {
> - return (struct task_struct *)(atomic_long_read(&lock->owner) & ~0x07);
> + return (struct task_struct *)(atomic_long_read(&lock->owner) & ~MUTEX_FLAGS);
> }

I would _much_ rather move __mutex_owner() out of line, you're exposing
far too much stuff.

\
 
 \ /
  Last update: 2019-07-29 13:08    [W:0.050 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site