Messages in this thread | | | From | Uladzislau Rezki <> | Date | Mon, 29 Jul 2019 12:02:54 +0200 | Subject | Re: [PATCH v3 2/3] augmented rbtree: add new RB_DECLARE_CALLBACKS_MAX macro |
| |
> > Note for Uladzislau Rezki, I noticed that the new augmented rbtree > code defines its own augment_tree_propagate_from function to update > the augmented subtree information after a node is modified; it would > probably be feasible to rely on the generated > free_vmap_area_rb_augment_cb_propagate function instead. mm/mmap.c > does something similar in vma_gap_update(), for a very similar use > case. > Just noticed this email due to vacation period, therefore it is a late replay.
Yes i have my own "populate" function and i knew about generated one because it is used during rotate operations. I a agree it makes sense to go with generated one to reduce the code size and get rid of duplication. I think we can rely on generated one otherwise it would not work at all. But i will double check.
-- Vlad Rezki
| |