lkml.org 
[lkml]   [2019]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 213/215] io_uring: ensure ->list is initialized for poll commands
    Date
    From: Jens Axboe <axboe@kernel.dk>

    commit 36703247d5f52a679df9da51192b6950fe81689f upstream.

    Daniel reports that when testing an http server that uses io_uring
    to poll for incoming connections, sometimes it hard crashes. This is
    due to an uninitialized list member for the io_uring request. Normally
    this doesn't trigger and none of the test cases caught it.

    Reported-by: Daniel Kozak <kozzi11@gmail.com>
    Tested-by: Daniel Kozak <kozzi11@gmail.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/io_uring.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/fs/io_uring.c
    +++ b/fs/io_uring.c
    @@ -1489,6 +1489,8 @@ static int io_poll_add(struct io_kiocb *
    INIT_LIST_HEAD(&poll->wait.entry);
    init_waitqueue_func_entry(&poll->wait, io_poll_wake);

    + INIT_LIST_HEAD(&req->list);
    +
    mask = vfs_poll(poll->file, &ipt.pt) & poll->events;

    spin_lock_irq(&ctx->completion_lock);

    \
     
     \ /
      Last update: 2019-07-29 22:09    [W:4.164 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site