Messages in this thread | | | Date | Sun, 28 Jul 2019 14:45:33 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH 1/2] livepatch: Nullify obj->mod in klp_module_coming()'s error path |
| |
On Fri, Jul 19, 2019 at 02:28:39PM +0200, Miroslav Benes wrote: > klp_module_coming() is called for every module appearing in the system. > It sets obj->mod to a patched module for klp_object obj. Unfortunately > it leaves it set even if an error happens later in the function and the > patched module is not allowed to be loaded. > > klp_is_object_loaded() uses obj->mod variable and could currently give a > wrong return value. The bug is probably harmless as of now. > > Signed-off-by: Miroslav Benes <mbenes@suse.cz> > Reviewed-by: Petr Mladek <pmladek@suse.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
-- Josh
| |