| Subject | Re: [RFC PATCH 04/40] soundwire: intel: add debugfs register dump | From | Cezary Rojewski <> | Date | Fri, 26 Jul 2019 11:35:44 +0200 |
| |
On 2019-07-26 01:39, Pierre-Louis Bossart wrote: > +static void intel_debugfs_init(struct sdw_intel *sdw) > +{ > + struct dentry *root = sdw->cdns.bus.debugfs; > + > + if (!root) > + return; > + > + sdw->fs = debugfs_create_dir("intel-sdw", root); > + if (IS_ERR_OR_NULL(sdw->fs)) { > + dev_err(sdw->cdns.dev, "debugfs root creation failed\n"); > + sdw->fs = NULL; > + return; > + } > + > + debugfs_create_file("intel-registers", 0400, sdw->fs, sdw, > + &intel_reg_fops); > + > + sdw_cdns_debugfs_init(&sdw->cdns, sdw->fs); > +}
I believe there should be dummy equivalent of _init and _exit if debugfs is not enabled (if these are defined already and I've missed it, please ignore).
> +static void intel_debugfs_exit(struct sdw_intel *sdw) > +{ > + debugfs_remove_recursive(sdw->fs); > +}
|