Messages in this thread | | | Date | Fri, 26 Jul 2019 12:10:38 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v3 08/13] recordmcount: Clarify what cleanup() does |
| |
On Wed, 24 Jul 2019 14:05:02 -0700 Matt Helsley <mhelsley@vmware.com> wrote:
> cleanup() mostly frees/unmaps the malloc'd/privately-mapped > copy of the ELF file recordmcount is working on, which is > set up in mmap_file(). It also deals with positioning within > the pseduo prive-mapping of the file and appending to the ELF > file. > > Split into two steps: > mmap_cleanup() for the mapping itself > file_append_cleanup() for allocations storing the > appended ELF data. > > Also, move the global variable initializations out of the main, > per-object-file loop and nearer to the alloc/init (mmap_file()) > and two cleanup functions so we can more clearly see how they're > related. > > Signed-off-by: Matt Helsley <mhelsley@vmware.com> > --- >
Hi Matt,
I reviewed up to this patch and they look fine. I may pull these in as I don't need a review form Josh for these patches.
Thanks!
-- Steve
| |