Messages in this thread | | | From | Vladimir Oltean <> | Date | Wed, 24 Jul 2019 13:17:52 +0300 | Subject | Re: [PATCH] net: dsa: sja1105: sja1105_main: Add of_node_put() |
| |
On Tue, 23 Jul 2019 at 23:38, David Miller <davem@davemloft.net> wrote: > > From: Nishka Dasgupta <nishkadg.linux@gmail.com> > Date: Tue, 23 Jul 2019 16:14:48 +0530 > > > Each iteration of for_each_child_of_node puts the previous node, but in > > the case of a return from the middle of the loop, there is no put, thus > > causing a memory leak. Hence add an of_node_put before the return. > > Issue found with Coccinelle. > > > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> > > Applied. > > Again, the semantics of these looping constructs are terrible.
Strange. Thanks for the fix.
-Vladimir
| |