lkml.org 
[lkml]   [2019]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 254/413] scsi: NCR5380: Handle PDMA failure reliably
    Date
    From: Finn Thain <fthain@telegraphics.com.au>

    commit f9dfed1c785734b95b08d67600e05d2092508ab0 upstream.

    A PDMA error is handled in the core driver by setting the device's 'borken'
    flag and aborting the command. Unfortunately, do_abort() is not
    dependable. Perform a SCSI bus reset instead, to make sure that the command
    fails and gets retried.

    Cc: Michael Schmitz <schmitzmic@gmail.com>
    Cc: stable@vger.kernel.org # v4.20+
    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
    Tested-by: Stan Johnson <userm57@yahoo.com>
    Tested-by: Michael Schmitz <schmitzmic@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/NCR5380.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    --- a/drivers/scsi/NCR5380.c
    +++ b/drivers/scsi/NCR5380.c
    @@ -1761,10 +1761,8 @@ static void NCR5380_information_transfer
    scmd_printk(KERN_INFO, cmd,
    "switching to slow handshake\n");
    cmd->device->borken = 1;
    - sink = 1;
    - do_abort(instance);
    - cmd->result = DID_ERROR << 16;
    - /* XXX - need to source or sink data here, as appropriate */
    + do_reset(instance);
    + bus_reset_cleanup(instance);
    }
    } else {
    /* Transfer a small chunk so that the

    \
     
     \ /
      Last update: 2019-07-24 22:39    [W:4.123 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site