lkml.org 
[lkml]   [2019]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 135/413] lightnvm: fix uninitialized pointer in nvm_remove_tgt()
    Date
    [ Upstream commit 2f5af4ab7de14bd35f3435e6a47300276bbb6c17 ]

    With gcc 4.1:

    drivers/lightnvm/core.c: In function ‘nvm_remove_tgt’:
    drivers/lightnvm/core.c:510: warning: ‘t’ is used uninitialized in this function

    Indeed, if no NVM devices have been registered, t will be an
    uninitialized pointer, and may be dereferenced later. A call to
    nvm_remove_tgt() can be triggered from userspace by issuing the
    NVM_DEV_REMOVE ioctl on the lightnvm control device.

    Fix this by preinitializing t to NULL.

    Fixes: 843f2edbdde085b4 ("lightnvm: do not remove instance under global lock")
    Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: Matias Bjørling <mb@lightnvm.io>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/lightnvm/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
    index 7d555b110ecd..a600934fdd9c 100644
    --- a/drivers/lightnvm/core.c
    +++ b/drivers/lightnvm/core.c
    @@ -478,7 +478,7 @@ static void __nvm_remove_target(struct nvm_target *t, bool graceful)
    */
    static int nvm_remove_tgt(struct nvm_ioctl_remove *remove)
    {
    - struct nvm_target *t;
    + struct nvm_target *t = NULL;
    struct nvm_dev *dev;

    down_read(&nvm_lock);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-07-24 22:39    [W:4.058 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site