lkml.org 
[lkml]   [2019]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 274/413] crypto: crypto4xx - fix a potential double free in ppc4xx_trng_probe
    Date
    From: Wen Yang <wen.yang99@zte.com.cn>

    commit 95566aa75cd6b3b404502c06f66956b5481194b3 upstream.

    There is a possible double free issue in ppc4xx_trng_probe():

    85: dev->trng_base = of_iomap(trng, 0);
    86: of_node_put(trng); ---> released here
    87: if (!dev->trng_base)
    88: goto err_out;
    ...
    110: ierr_out:
    111: of_node_put(trng); ---> double released here
    ...

    This issue was detected by using the Coccinelle software.
    We fix it by removing the unnecessary of_node_put().

    Fixes: 5343e674f32f ("crypto4xx: integrate ppc4xx-rng into crypto4xx")
    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Cc: <stable@vger.kernel.org>
    Cc: "David S. Miller" <davem@davemloft.net>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Allison Randal <allison@lohutok.net>
    Cc: Armijn Hemel <armijn@tjaldur.nl>
    Cc: Julia Lawall <Julia.Lawall@lip6.fr>
    Cc: linux-crypto@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    Acked-by: Julia Lawall <julia.lawall@lip6.fr>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/crypto/amcc/crypto4xx_trng.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/crypto/amcc/crypto4xx_trng.c
    +++ b/drivers/crypto/amcc/crypto4xx_trng.c
    @@ -108,7 +108,6 @@ void ppc4xx_trng_probe(struct crypto4xx_
    return;

    err_out:
    - of_node_put(trng);
    iounmap(dev->trng_base);
    kfree(rng);
    dev->trng_base = NULL;

    \
     
     \ /
      Last update: 2019-07-24 22:39    [W:2.875 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site