lkml.org 
[lkml]   [2019]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 290/413] regulator: s2mps11: Fix ERR_PTR dereference on GPIO lookup failure
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    commit 70ca117b02f3b1c8830fe95e4e3dea2937038e11 upstream.

    If devm_gpiod_get_from_of_node() call returns ERR_PTR, it is assigned
    into an array of GPIO descriptors and used later because such error is
    not treated as critical thus it is not propagated back to the probe
    function.

    All code later expects that such GPIO descriptor is either a NULL or
    proper value. This later might lead to dereference of ERR_PTR.

    Only devices with S2MPS14 flavor are affected (other do not control
    regulators with GPIOs).

    Fixes: 1c984942f0a4 ("regulator: s2mps11: Pass descriptor instead of GPIO number")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/regulator/s2mps11.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/regulator/s2mps11.c
    +++ b/drivers/regulator/s2mps11.c
    @@ -826,6 +826,7 @@ static void s2mps14_pmic_dt_parse_ext_co
    else if (IS_ERR(gpio[reg])) {
    dev_err(&pdev->dev, "Failed to get control GPIO for %d/%s\n",
    reg, rdata[reg].name);
    + gpio[reg] = NULL;
    continue;
    }
    if (gpio[reg])

    \
     
     \ /
      Last update: 2019-07-24 21:37    [W:2.882 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site