Messages in this thread | | | From | Rob Herring <> | Date | Tue, 23 Jul 2019 13:30:48 -0600 | Subject | Re: [PATCH v4 2/3] treewide: Remove dev_err() usage after platform_get_irq() |
| |
On Tue, Jul 23, 2019 at 12:16 PM Stephen Boyd <swboyd@chromium.org> wrote: > > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch.
Nice. Would be nice to see this for other commonly called functions in probe though we have deal with cases of failure being okay.
> > // <smpl> > @@ > expression ret; > struct platform_device *E; > @@ > > ret = > ( > platform_get_irq(E, ...) > | > platform_get_irq_byname(E, ...) > ); > > if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > -{ ... > -dev_err(...); > -... } > | > ... > -dev_err(...);
What about cases of pr_err, pr_warn, etc.? And the subsystem specific prints like edac_printk and DRM_ERROR/DRM_DEV_ERROR.
There's also some cases that the irq seems to be optional. They use dev_info, but will now have an error level print. That's fine with me, but some may complain...
> ) > ... > } > // </smpl> > > Cc: Rob Herring <robh@kernel.org> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Javier Martinez Canillas <javierm@redhat.com> > Cc: Andrzej Hajda <a.hajda@samsung.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Russell King - ARM Linux <linux@armlinux.org.uk> > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
| |