Messages in this thread | | | From | Ravi Chandra Sadineni <> | Date | Tue, 23 Jul 2019 09:56:55 -0700 | Subject | Re: [PATCH 0/2] power: Refactor device level sysfs. |
| |
Hi Greg,
https://patchwork.kernel.org/patch/11045069/ seems to create a virtual device under wakeup class with the same name as the actual device. I don't see a way to reliably map these virtual devices to the actual device sysfs node. For example if we have to know if a particular input device has triggered a wake event, we have to look for a virtual device under /sys/class/wakeup with the same name. I am afraid that depending just on the name might be too risky as there can be multiple devices under different buses with the same name. Am I missing something?
Thanks, Ravi
On Tue, Jul 23, 2019 at 12:44 AM Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Tue, Jul 23, 2019 at 12:33 AM Ravi Chandra Sadineni > <ravisadineni@chromium.org> wrote: > > > > wakeup_abort_count and wakeup_count attributes print the > > same (wakeup_count) variable. Thus this patchset removes the > > duplicate wakeup_abort_count sysfs attribute. This patchset also > > exposes event_count as a sysfs attribute. > > > > Ravi Chandra Sadineni (2): > > power: sysfs: Remove wakeup_abort_count attribute. > > power:sysfs: Expose device wakeup_event_count. > > I don't think you need this at all, because > https://patchwork.kernel.org/patch/11045069/ is exposing what you need > already. > > Thanks!
| |