Messages in this thread | | | Date | Tue, 23 Jul 2019 15:39:52 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: act8865: support regulator-pull-down property |
| |
On Tue, Jul 23, 2019 at 02:09:38PM +0200, Michał Mirosław wrote: > On Tue, Jul 23, 2019 at 11:54:32AM +0100, Mark Brown wrote: > > On Mon, Jul 22, 2019 at 08:13:29PM +0200, Michał Mirosław wrote: > > > AC8865 has internal 1.5k pull-down resistor that can be enabled when LDO > > > is shut down.
> > This changelog...
> > > static const struct regulator_ops act8865_ldo_ops = { > > > + .list_voltage = regulator_list_voltage_linear_range, > > > + .map_voltage = regulator_map_voltage_linear_range, > > > + .get_voltage_sel = regulator_get_voltage_sel_regmap, > > > + .set_voltage_sel = regulator_set_voltage_sel_regmap,
> > ...doesn't obviously match this code change which looks to be > > implementing voltage setting (as well as the pull down stuff but still).
> It's just an diff-artifact of changing act8865_ldo_ops meaning. It's > now a copy of act8865_ops with .set_pull_down added. Previous > act8865_ldo_ops is act8865_fixed_ldo_ops now.
If there's that big a refactoring it probably warrants a separate patch, and it definitely should be called out in the changelog. Like I say the changbelog does not describe the change at all well. [unhandled content-type:application/pgp-signature] | |