lkml.org 
[lkml]   [2019]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/5] OPP: Improve require-opps linking
$subject doesn't have correct property name.

On 17-07-19, 15:23, Saravana Kannan wrote:
> Currently, the linking of required-opps fails silently if the
> destination OPP table hasn't been added before the source OPP table is
> added. This puts an unnecessary requirement that the destination table
> be added before the source table is added.
>
> In reality, the destination table is needed only when we try to
> translate from source OPP to destination OPP. So, instead of
> completely failing, retry linking the tables when the translation is
> attempted.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
> drivers/opp/core.c | 32 +++++++++++-----
> drivers/opp/of.c | 91 ++++++++++++++++++++++------------------------
> drivers/opp/opp.h | 5 +++
> 3 files changed, 71 insertions(+), 57 deletions(-)

Here is the general feedback and requirements I have:

- We shouldn't do it from _set_required_opps() but way earlier, it
shouldn't affect the fast path (where we change the frequency).

- Programming required-opps for half of the properties isn't correct,
i.e. in case only few of the required-opps are parsed until now. So
setting of rate shouldn't even start unless the OPP table is fully
initialized with all required-opps in it.

--
viresh

\
 
 \ /
  Last update: 2019-07-23 12:29    [W:0.221 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site