Messages in this thread | | | Subject | Re: [PATCH v2 02/10] iio: document bindings for mounting matrices | From | "H. Nikolaus Schaller" <> | Date | Tue, 23 Jul 2019 11:46:49 +0200 |
| |
Hi Linus,
> Am 23.07.2019 um 09:42 schrieb Linus Walleij <linus.walleij@linaro.org>: > > Hi H. Nikolaus, > > On Thu, Feb 21, 2019 at 6:03 PM H. Nikolaus Schaller <hns@goldelico.com> wrote: > >> From: Linus Walleij <linus.walleij@linaro.org> > > It is fair for you to change authorship to yourself at this point. > Just keeping my Signed-off-by is sufficient.
Well, I think my contribution is less than yours :)
> >> The mounting matrix for sensors was introduced in >> commit dfc57732ad38 ("iio:core: mounting matrix support") >> >> However the device tree bindings are very terse and since this is >> a widely applicable property, we need a proper binding for it >> that the other bindings can reference. This will also be useful >> for other operating systems and sensor engineering at large. >> >> I think all 3D sensors should support it, the current situation >> is probably that the mounting information is confined in magic >> userspace components rather than using the mounting matrix, which >> is not good for portability and reuse. >> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: Gregor Boirie <gregor.boirie@parrot.com> >> Cc: Sebastian Reichel <sre@kernel.org> >> Cc: Samu Onkalo <samu.onkalo@intel.com> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > > Did this patch fall off somewhere? I think it's really neat, even in this > form it is great help for developers. If you want I can try picking up the > comments and resend it.
Well, I had planned to review it again and promised to send out a new version. But as usual this ToDo becomes hidden by always more important tasks.
So I am fine if you can pick comments and resend it. I think there will be others who help to make it even better in the future if the mount matrix is more widely used.
BR, Nikolaus
| |