lkml.org 
[lkml]   [2019]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] RDMA/hns: Fix build error for hip08
    On Tue, Jul 23, 2019 at 10:49:08AM +0800, YueHaibing wrote:
    > If INFINIBAND_HNS_HIP08 is selected and HNS3 is m,
    > but INFINIBAND_HNS is y, building fails:
    >
    > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_exit':
    > hns_roce_hw_v2.c:(.exit.text+0xd): undefined reference to `hnae3_unregister_client'
    > drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_init':
    > hns_roce_hw_v2.c:(.init.text+0xd): undefined reference to `hnae3_register_client'

    It means that you have a problem with header files of your hns3.

    >
    > Reported-by: Hulk Robot <hulkci@huawei.com>
    > Fixes: dd74282df573 ("RDMA/hns: Initialize the PCI device for hip08 RoCE")
    > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    > ---
    > drivers/infiniband/hw/hns/Kconfig | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig
    > index b59da5d..4371c80 100644
    > --- a/drivers/infiniband/hw/hns/Kconfig
    > +++ b/drivers/infiniband/hw/hns/Kconfig
    > @@ -23,7 +23,8 @@ config INFINIBAND_HNS_HIP06
    >
    > config INFINIBAND_HNS_HIP08
    > bool "Hisilicon Hip08 Family RoCE support"
    > - depends on INFINIBAND_HNS && PCI && HNS3
    > + depends on INFINIBAND_HNS && (INFINIBAND_HNS = HNS3)

    This is wrong.

    > + depends on PCI
    > ---help---
    > RoCE driver support for Hisilicon RoCE engine in Hisilicon Hip08 SoC.
    > The RoCE engine is a PCI device.
    > --
    > 2.7.4
    >
    >

    \
     
     \ /
      Last update: 2019-07-23 09:44    [W:4.789 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site