Messages in this thread | | | Subject | Re: [PATCH v2 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock() | From | John Hubbard <> | Date | Tue, 23 Jul 2019 18:31:40 -0700 |
| |
On 7/23/19 6:26 PM, john.hubbard@gmail.com wrote: > From: John Hubbard <jhubbard@nvidia.com> ... > + * 2) This code sees the page as clean, so it calls > + * set_page_dirty(). The page stays dirty, despite being > + * written back, so it gets written back again in the > + * next writeback cycle. This is harmless. > + */ > + if (!PageDirty(page)) > + set_page_dirty_lock(page); > + break;
ahem, the above "break" should not be there, it's an artifact, sorry about that. Will correct on the next iteration.
thanks, -- John Hubbard NVIDIA
> + put_user_page(page); > + } > } > EXPORT_SYMBOL(put_user_pages_dirty_lock); > >
| |