Messages in this thread | | | Date | Mon, 22 Jul 2019 10:04:14 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] lib: zstd: Make ZSTD_compressBlock_greedy_extDict static |
| |
On Wed, Jul 17, 2019 at 05:18:52PM +0800, YueHaibing wrote: > Fix sparse warnings: > > lib/zstd/compress.c:2252:6: warning: > symbol 'ZSTD_compressBlock_greedy_extDict' was not declared. Should it be static? > lib/zstd/compress.c:2982:14: warning: > symbol 'ZSTD_createCStream_advanced' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> --- > lib/zstd/compress.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/lib/zstd/compress.c b/lib/zstd/compress.c > index 5e0b67003e55..651d686c00b6 100644 > --- a/lib/zstd/compress.c > +++ b/lib/zstd/compress.c > @@ -2249,7 +2249,11 @@ void ZSTD_compressBlock_lazy_extDict_generic(ZSTD_CCtx *ctx, const void *src, si > } > } > > -void ZSTD_compressBlock_greedy_extDict(ZSTD_CCtx *ctx, const void *src, size_t srcSize) { ZSTD_compressBlock_lazy_extDict_generic(ctx, src, srcSize, 0, 0); } > +static void ZSTD_compressBlock_greedy_extDict(ZSTD_CCtx *ctx, const void *src, > + size_t srcSize) > +{ > + ZSTD_compressBlock_lazy_extDict_generic(ctx, src, srcSize, 0, 0); > +} > > static void ZSTD_compressBlock_lazy_extDict(ZSTD_CCtx *ctx, const void *src, size_t srcSize) > { > @@ -2979,7 +2983,7 @@ size_t ZSTD_CStreamWorkspaceBound(ZSTD_compressionParameters cParams) > return ZSTD_CCtxWorkspaceBound(cParams) + ZSTD_ALIGN(sizeof(ZSTD_CStream)) + ZSTD_ALIGN(inBuffSize) + ZSTD_ALIGN(outBuffSize); > } > > -ZSTD_CStream *ZSTD_createCStream_advanced(ZSTD_customMem customMem) > +static ZSTD_CStream *ZSTD_createCStream_advanced(ZSTD_customMem customMem) > { > ZSTD_CStream *zcs; > > -- > 2.20.1 > >
-- Kees Cook
| |