Messages in this thread | | | Subject | Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support | From | "Ji-Ze Hong (Peter Hong)" <> | Date | Mon, 22 Jul 2019 16:36:53 +0800 |
| |
Hi Marc,
Marc Kleine-Budde 於 2019/7/22 下午 04:15 寫道: > On 7/22/19 8:22 AM, Ji-Ze Hong (Peter Hong) wrote: >> +/* Probe F81601 based device for the SJA1000 chips and register each >> + * available CAN channel to SJA1000 Socket-CAN subsystem. >> + */ >> +static int f81601_pci_add_card(struct pci_dev *pdev, >> + const struct pci_device_id *ent) >> +{ >> + struct sja1000_priv *priv; >> + struct net_device *dev; >> + struct f81601_pci_card *card; >> + int err, i, count; >> + u8 tmp; >> + >> + if (pcim_enable_device(pdev) < 0) { > > I'm missing a corresponding disable_device(). > I'm using managed pcim_enable_device(), Does it need call pci_disable_device() ??
Thanks -- With Best Regards, Peter Hong
| |