Messages in this thread | | | Date | Sun, 21 Jul 2019 11:38:15 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] drm/panel: simple: Doxygenize 'struct panel_desc'; rename a few functions |
| |
Hi Doug.
On Wed, Jul 17, 2019 at 07:33:17PM +0200, Sam Ravnborg wrote: > Hi Doug. > > On Fri, Jul 12, 2019 at 09:33:33AM -0700, Douglas Anderson wrote: > > This attempts to address outstanding review feedback from commit > > b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical > > timing"). Specifically: > > > > * It was requested that I document (in the structure definition) that > > the device tree override had no effect if 'struct drm_display_mode' > > was used in the panel description. I have provided full Doxygen > > comments for 'struct panel_desc' to accomplish that. > > * panel_simple_get_fixed_modes() was thought to be a confusing name, > > so it has been renamed to panel_simple_get_display_modes(). > > * panel_simple_parse_override_mode() was thought to be better named as > > panel_simple_parse_panel_timing_node(). > > > > Suggested-by: Sam Ravnborg <sam@ravnborg.org> > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > Thanks. > > I updated the $subject to: > drm/panel: simple: document panel_desc; rename a few functions > > And pushed out to drm-misc-next.
I see the following error printed at each boot:
/panel: could not find node 'panel-timing'
The error originates from this snip (from panel-simple.c):
if (!of_get_display_timing(dev->of_node, "panel-timing", &dt)) panel_simple_parse_panel_timing_node(dev, panel, &dt);
of_get_display_timing() returns -2 (-ENOENT).
In the setup I use there is no panel-timing node as the timing specified in panel-simple.c is fine. This is the typical setup - and there should not in the normal case be printed error messages like this during boot.
Will you please take a look at this.
Sam
| |